You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add/update the appropriate package README (if applicable)
Add/update the related module in the docs demo (if applicable)
Add/update the related package in the docs/package.json file (if applicable)
If this PR includes changes to add an injected wallet or SDK wallet module:
Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/
Thanks for so much for the PR to add SolidJs support! Any chance you could add a small example here in our examples section?
If so I will get this tested and published along with getting a section added to our docs as well.
You can also remove the pnpm lock file when you have a moment.
Thanks again!
@yisacc friendly ping on the above comments. It would be very helpful to have a SolidJS example to go along with this within the web3-onboard repo examples section.
There also seems to be some issues with the required node version for the new package causing build errors. Please see failing PR Status Checks below
Thanks!
@yisacc we would love to get this merged - can you take a look at the failing PR checks and add a small boilerplate example to the examples folder when you have a moment?
@yisacc we would love to get this merged - can you take a look at the failing PR checks and add a small boilerplate example to the examples folder when you have a moment?
@yisacc we would love to get this merged - can you take a look at the failing PR checks and add a small boilerplate example to the examples folder when you have a moment?
@yisacc does solidjs require node version 18? The requirement in the package.json is causing issues with our build system as our minimum requirement is node v16
@yisacc thanks for that! I am doing some final testing and will add to our docs site.
Can you add an super simple example to the /examples/ within the repo with a connect btn?
If you can add this I can get this package out in the release today/tomorrow!
This is specifically helpful if webpack or some other bundler configs are required
@yisacc thanks for that! I am doing some final testing and will add to our docs site. Can you add an super simple example to the /examples/ within the repo with a connect btn? If you can add this I can get this package out in the release today/tomorrow! This is specifically helpful if webpack or some other bundler configs are required
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add solidJS support implemented solid package to enable solid reactivity when web3-onboard is used with in a solidjs codebase.
PLEASE NOTE- Checklist must be complete prior to review.
Checklist
package.jsonof the package you have made changes in following semantic versioning and using alpha release taggingyarn check-allto confirm there are not any associated errorsDocs Checklist
docs/package.jsonfile (if applicable)If this PR includes changes to add an injected wallet or SDK wallet module:
Please complete the following using the internal demo package.
To run this demo use the command
yarn && yarn devto get the project running athttp://localhost:8080/Tests with demo app (injected)
Tests with demo app (SDK)